[asan] Fix argv array for PyROOT applications#22768
Merged
Merged
Conversation
pick these changes from root-project#22746: - The argv array for PyROOT applications was one element too small This fixes 20 failing pyunittests on Windows. Thanks @hageboeck!
guitargeek
approved these changes
Jul 7, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
Fantastic, LGTM!
Interesting that it only became an issue now
hageboeck
approved these changes
Jul 7, 2026
Test Results 23 files 23 suites 3d 13h 15m 26s ⏱️ For more details on these failures, see this check. Results for commit 2d2da10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick these changes from #22746:
This fixes 20 failing pyunittests on Windows. Thanks @hageboeck!